Fetch item class for each row of the data #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviks789
force-pushed
the
fetch-item-class-based-on-row
branch
from
83346c1
to
9c073cc
Compare
nilmerg
requested changes
Sep 19, 2024
raviks789
force-pushed
the
fetch-item-class-based-on-row
branch
from
9c073cc
to
b2aedf9
Compare
nilmerg
requested changes
Sep 19, 2024
raviks789
force-pushed
the
fetch-item-class-based-on-row
branch
2 times, most recently
from
b681739
to
df5da6e
Compare
nilmerg
requested changes
Sep 19, 2024
raviks789
force-pushed
the
fetch-item-class-based-on-row
branch
from
df5da6e
to
68c3240
Compare
nilmerg
approved these changes
Sep 19, 2024
nilmerg
added a commit
to Icinga/icingadb-web
that referenced
this pull request
Oct 31, 2024
…dency (#1057) ref #1050 blocked by: #1055 blocked by: Icinga/ipl-web#231, Icinga/ipl-web#234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is assumed that each list item in the list will be of same instance. Hence, calling
getItemClass()method once in theassemble()method was sufficient to obtain the instance of the list item and build the entire list.But if we want to build a list containing list items of different instances, we would have to obtain the instance for each list item. For instance, the root problem list for dependencies contains host, service or redundancy group. Hence, the list item can be an instance of
HostListItem,ServiceListItemorRedundancyGroupListItem.In which case, it would require us to rewrite parent
assemble()method, which is not desirable. To avoid thiscreateListItem()method must be introduced, that will be responsible for creating the list item.